Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

46567 Fix unit test errors #792

Merged
merged 1 commit into from
Apr 4, 2024
Merged

46567 Fix unit test errors #792

merged 1 commit into from
Apr 4, 2024

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Apr 3, 2024

changed log:
Fix unit test errors nullable type changes

@dai-eastgate
Copy link
Contributor Author

dai-eastgate commented Apr 3, 2024

@andernath After investigating the test failures, it seems they are likely due to the release nullable type changes introduced in PHPUnit 9.6.18, as discussed in PHPUnit issue #5763.
Please review and merge if appropriate.

Copy link

github-actions bot commented Apr 4, 2024

Steps to install the approved version:

  1. Download onoffice-4.18.1-12-gbb1ef11c-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/8551561822.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath merged commit 25f5a3f into master Apr 4, 2024
6 checks passed
@andernath andernath deleted the 46567-fix-unit-test branch April 4, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants