New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OAuth2 Support #354

Merged

arvindkrishnakumar-okta merged 66 commits into master from feature_add_oauth2_support

Apr 30, 2020

Contributor

arvindkrishnakumar-okta commented Apr 2, 2020

No description provided.

arvindkrishnakumar-okta added 2 commits

April 1, 2020 23:57


          Add OAuth Support

8dc674b


          Add OAuth Support - Minor Refactor

d272d22

arvindkrishnakumar-okta commented

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/util/OAuth2Utils.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

THIRD-PARTY-NOTICES Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

api/src/main/java/com/okta/sdk/authc/credentials/OAuth2ClientCredentials.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/pom.xml Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/pom.xml Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/pom.xml Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/pom.xml Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/client/DefaultClientBuilder.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/client/DefaultClientBuilder.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/client/DefaultClientBuilder.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/util/OAuth2Utils.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/util/OAuth2Utils.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/util/OAuth2Utils.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/util/OAuth2Utils.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/util/OAuth2Utils.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/util/OAuth2Utils.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/util/OAuth2Utils.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/util/OAuth2Utils.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

pom.xml Show resolved Hide resolved

bdemers reviewed

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

src/license/mapping.xml Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

src/license/mapping.xml Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

src/license/mapping.xml Outdated Show resolved Hide resolved

bdemers suggested changes

View reviewed changes

Contributor

bdemers left a comment

See comments


          Add OAuth Support - added Unit tests and did some refactoring

01393d5

arvindkrishnakumar-okta requested a review from robertdamphousse-okta

April 2, 2020 19:12

bdemers reviewed

View reviewed changes

integration-tests/src/test/groovy/com/okta/sdk/tests/it/util/ClientProvider.groovy Outdated Show resolved Hide resolved

bdemers suggested changes

View reviewed changes

Contributor

bdemers left a comment

See comments

arvindkrishnakumar-okta added 4 commits

April 23, 2020 10:34


          Review comments addressed

04c5c3e


          Added double null check on OAuth2AccessToken object for synchronization

efc0894


          Updated licence header in findbugs-exclude.xml

2703c15


          Refactored concurrency code in OAuth2RequestAuthenticator and added u…

45c1b44

…nit tests for it

arvindkrishnakumar-okta requested a review from bdemers

April 24, 2020 06:13

arvindkrishnakumar-okta added 2 commits

April 24, 2020 09:47


          Refactored concurrency test

7a6dd62


          Merge branch 'master' into feature_add_oauth2_support

e0e2699

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/api/OAuth2ApiClientCredentialsResolver.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/oauth2/OAuth2ClientCredentials.java Show resolved Hide resolved

bdemers reviewed

View reviewed changes

src/findbugs/findbugs-exclude.xml Outdated Show resolved Hide resolved

bdemers reviewed

View reviewed changes

src/findbugs/findbugs-exclude.xml Outdated Show resolved Hide resolved

bdemers suggested changes

View reviewed changes

Contributor

bdemers left a comment

a couple minor items


          Review comments addressed

ea4f521

arvindkrishnakumar-okta requested a review from bdemers

April 27, 2020 18:57

bdemers approved these changes

View reviewed changes

Contributor

bdemers left a comment

Woot!
Make sure CI is green and merge it!

arvindkrishnakumar-okta requested a review from bdemers

April 27, 2020 20:55

bretterer approved these changes

View reviewed changes

Collaborator

bretterer left a comment

Looks good to me. Lots of work has been done here! Thanks!

laura-rodriguez reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

laura-rodriguez reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/http/authc/OAuth2RequestAuthenticator.java Show resolved Hide resolved

laura-rodriguez reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java Show resolved Hide resolved

laura-rodriguez reviewed

View reviewed changes

impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java Show resolved Hide resolved

laura-rodriguez approved these changes

View reviewed changes

Collaborator

laura-rodriguez left a comment

A couple of minor notes but overall it looks good!


          Reverted the added OAuth2 specific changes to README as this will be …

a44242a

…taken care in a new PR

arvindkrishnakumar-okta requested a review from laura-rodriguez

April 29, 2020 17:18

arvindkrishnakumar-okta merged commit 6aba34c into master

arvindkrishnakumar-okta deleted the feature_add_oauth2_support branch

April 30, 2020 03:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bretterer bretterer approved these changes

robertdamphousse-okta Awaiting requested review from robertdamphousse-okta

aarongranick-okta Awaiting requested review from aarongranick-okta

vijetmahabaleshwar-okta Awaiting requested review from vijetmahabaleshwar-okta

bdemers Awaiting requested review from bdemers

laura-rodriguez Awaiting requested review from laura-rodriguez