Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invoking logout without credentials no longer throws error #37

Closed
wants to merge 2 commits into from

Conversation

jaredperreault-okta
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • [X ] Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ X] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • [X ] Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Invoking logout without valid credentials throws error

Issue Number: 436562

What is the new behavior?

401 is returned when logout is called without credentials

Does this PR introduce a breaking change?

  • Yes
  • [X ] No

Other information

Reviewers

@jaredperreault-okta jaredperreault-okta changed the base branch from master to 4.3 November 30, 2021 16:09
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Nov 30, 2021
OKTA-436562
<<<Jenkins Check-In of Tested SHA: 25daa00 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-oidc-middleware
Files changed count: 3
PR Link: "#37"
@denysoblohin-okta denysoblohin-okta mentioned this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants