Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get authorize and endssession URLs from OIDC client #34

Closed

Conversation

oleksandrpravosudko-okta
Copy link
Contributor

@oleksandrpravosudko-okta oleksandrpravosudko-okta commented Nov 17, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@oleksandrpravosudko-okta oleksandrpravosudko-okta changed the base branch from master to 4.3 November 17, 2021 10:30
@oleksandrpravosudko-okta oleksandrpravosudko-okta changed the base branch from 4.3 to master November 17, 2021 12:55
@@ -1,3 +1,9 @@
# 4.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to 4.3? test release after the repo migration? maybe add one line of description in the changelog?

eng-prod-CI-bot-okta pushed a commit that referenced this pull request Nov 17, 2021
OKTA-437624
<<<Jenkins Check-In of Tested SHA: 01e6cd3 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-oidc-middleware
Files changed count: 4
PR Link: "#34"
oleksandrpravosudko-okta added a commit that referenced this pull request Nov 19, 2021
OKTA-437624
<<<Jenkins Check-In of Tested SHA: 01e6cd3 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-oidc-middleware
Files changed count: 4
PR Link: "#34"
oleksandrpravosudko-okta added a commit that referenced this pull request Nov 19, 2021
OKTA-437624
<<<Jenkins Check-In of Tested SHA: 01e6cd3 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-oidc-middleware
Files changed count: 4
PR Link: "#34"
@denysoblohin-okta denysoblohin-okta mentioned this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants