Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validate): add check receiver pointer #1082

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

sashamelentyev
Copy link
Contributor

When use Validate() in handler, if handler takes nil - we have panic

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f604144) 72.52% compared to head (893026c) 72.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
+ Coverage   72.52%   72.54%   +0.01%     
==========================================
  Files         192      192              
  Lines       15049    15049              
==========================================
+ Hits        10915    10917       +2     
+ Misses       3593     3592       -1     
+ Partials      541      540       -1     
Files Coverage Δ
validate/error.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdakkota tdakkota enabled auto-merge October 30, 2023 23:13
@tdakkota tdakkota merged commit 5d93753 into ogen-go:main Oct 30, 2023
@sashamelentyev sashamelentyev deleted the feat/valid-receiver branch October 31, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants