Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): switch to esbuild #430

Merged
merged 3 commits into from Jun 1, 2023
Merged

fix(build): switch to esbuild #430

merged 3 commits into from Jun 1, 2023

Conversation

kfcampbell
Copy link
Member

Replicating octokit/request.js#584 to another repo.


Pika has been deprecated for a while now, and the project has now been archived, and because of that the released npm package is missing most of the files generated by the build step.

Uses esbuild to transpile the TS source code into an ESM source, NodeJs bundle, and a browser bundle

Uses the TypeScript compiler to generate the types.

Behavior

Before the change?

  • Uses pika for the build system
  • The released npm package is missing most of the files generated by the build step. dist-node, dist-types, dist-web... even though they are generated correctly.

After the change?

  • Uses esbuild to generate the JS bundles
  • Uses the TypeScript compiler to generate the type definitions
  • The correct file matching patterns are used so we publish all the necessary files again.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Dependencies/code cleanup: Type: Maintenance

@kfcampbell kfcampbell requested a review from wolfy1339 June 1, 2023 22:52
@ghost ghost added this to Inbox in JS Jun 1, 2023
@kfcampbell kfcampbell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 1, 2023
@ghost ghost moved this from Inbox to Maintenance in JS Jun 1, 2023
test/retry.test.ts Outdated Show resolved Hide resolved
@kfcampbell kfcampbell merged commit f755e88 into main Jun 1, 2023
8 checks passed
@kfcampbell kfcampbell deleted the switch-to-esbuild branch June 1, 2023 23:03
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

🎉 This PR is included in version 4.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

package.json Show resolved Hide resolved
benmvp added a commit to benmvp/plugin-retry.js that referenced this pull request Jun 2, 2023
octokit#430 upgraded the Node version to 18, but as a fix (instead of a breaking change). So it breaks consumers of the library (such as [`semantic-release`](https://github.com/semantic-release/semantic-release)) that are still on Node 16.

Fixes octokit#431
wolfy1339 pushed a commit that referenced this pull request Jun 2, 2023
#430 upgraded the Node version to 18, but as a fix (instead of a breaking change). So it breaks consumers of the library (such as [`semantic-release`](https://github.com/semantic-release/semantic-release)) that are still on Node 16.

Fixes #431
@G-Rath G-Rath mentioned this pull request Jun 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
JS
  
Maintenance
Development

Successfully merging this pull request may close these issues.

None yet

4 participants