[BUG]: last commit was detected as a fix instead of breaking change (node version) #431
Closed
1 task done
Comments
existe-deja
added
Status: Triage
ghost
added this to Bugs
in 
|
Example reproduction where I encounter the same issue: Yarn can't resolve due to the constraint. I require 16 as well. |
|
You linked to the wrong commit. Those changes weren't meant to be breaking. It was only supposed to change the build system. Feel free to send a PR if you would like to. I don't have time to get around to this soon |
wolfy1339
added
Priority: High
and removed
Status: Triage
|
It's this commit: https://github.com/octokit/plugin-retry.js/blame/main/package.json#L85 |
benmvp
added a commit
to benmvp/plugin-retry.js
that referenced
this issue
Jun 2, 2023
octokit#430 upgraded the Node version to 18, but as a fix (instead of a breaking change). So it breaks consumers of the library (such as [`semantic-release`](https://github.com/semantic-release/semantic-release)) that are still on Node 16. Fixes octokit#431
This was referenced Jun 2, 2023
|
Here's a PR for the fix: #432 |
wolfy1339
pushed a commit
that referenced
this issue
Jun 2, 2023
#430 upgraded the Node version to 18, but as a fix (instead of a breaking change). So it breaks consumers of the library (such as [`semantic-release`](https://github.com/semantic-release/semantic-release)) that are still on Node 16. Fixes #431
|
🎉 This issue has been resolved in version 4.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
the package isn't supporting node >= 16 so I can't install my project. This is because of BREAKING CHANGE of this commit wasn't detected
Versions
@octokit/plugin-retry@4.1.4
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: