Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add RequiredSignatures to the BranchProtectionSettingsUpdate Type #2873

Merged
merged 2 commits into from Feb 5, 2024

Conversation

wesdevpro
Copy link
Contributor

@wesdevpro wesdevpro commented Feb 2, 2024

Resolves #2855


Before the change?

  • No RequiredSignatures property present for BranchProtectionSettingsUpdate type which is supported by GitHub's rest APIs.

After the change?

  • Added RequiredSignatures property for the BranchProtectionSettingsUpdate type
  • Updated all xUnnit tests for the BranchProtectionSettingsUpdate type to account for the new property (i.e RequiredSignatures)

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

…e` types.

- Fixes #2855
- Updated `BranchProtectionSettingsUpdate` by adding `RequiredSignatures`.
- Update all integration `xUnit` tests to check for the `RequiredSignatures` property.
@kfcampbell kfcampbell merged commit 350b8fe into octokit:main Feb 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: BranchProtectionSettingsUpdate type is missing a bool property for RequiredSignatures.
2 participants