Fix DeploymentStatus IDs Overflowing #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
force-pushed
the
FixDeploymentStatuses
branch
from
4d25f94
to
50e592d
Compare
|
This issue broke our production environment |
nickfloyd
added
Type: Breaking change
|
Hey @Cyberboss thank you so much for catching this ❤️ . I am fast-tracking this and will be sending it out the door shortly! |
nickfloyd
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2735
Behavior
Before the change?
Newly created
DeploymentStatuses on github.com recently exceeded the limits of a 32-bit signed integer, causingOverflowExceptions to be throw during de-serialization.After the change?
The de-serialization no longer throws due to the
DeploymentStatus.Idfield being upgraded to a 64-bit signed integer.Other information
Was this the reason for the GitHub API outages in the past 48 hours? lmao.
Additional info
Pull request checklist
- [ ] Added the appropriate label for the given change(Not a maintainer)Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)- [ ] NoIf
Yes, what's the impact:DeploymentStatus.Idcan no longer be safely assigned to anInt32, it's previous type.Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug