gha: use latest Visual Studio compiler #13174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just executing |
It gives a version, but not the toolset version. We can already see the cl version from the vendor string. |
gasche
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI for MSVC/clang-cl have started failing, because as per actions/runner-images#9701, GitHub has removed all VC++ toolsets except the latest one (for now it's 14.39). That's why the version 14.38 was not found. (see also ilammy/msvc-dev-cmd#80).
If we don't hard-code a version, then the action will default to the latest toolset. I haven't found a way to (at least) log the version that's used. I haven't looked at installing a specific version. I think we're fine defaulting to the latest available version.