Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix semver rule #46

Merged
merged 3 commits into from
Nov 19, 2023
Merged

fix semver rule #46

merged 3 commits into from
Nov 19, 2023

Conversation

djukxe
Copy link
Contributor

@djukxe djukxe commented Nov 19, 2023

Following introduction of semver in #42, this PR is to fix couple of issues in the rule used to detect if desired java version is installed or not

Hopefully fixes nvuillam/npm-groovy-lint#321

Proposed Changes

  1. Handle case where minimumJavaVersion and maximumJavaversion are set with same values (like npm-groovy-lint)
  2. Fix regression as maximumJavaVersion is supposed to be included not excluded

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG.md listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7780910) 90.27% compared to head (8311fbd) 90.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   90.27%   90.41%   +0.13%     
==========================================
  Files           3        3              
  Lines         216      219       +3     
==========================================
+ Hits          195      198       +3     
  Misses         21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, I'll apply that to npm-groovy-lint asap :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem detecting existing Java 17 installation and installing new build for no reason
3 participants