Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): always fullscreen on mobile #2637

Merged
merged 10 commits into from
Feb 16, 2025

Conversation

sandros94
Copy link
Member

πŸ”— Linked issue

Resolves #2463

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It is counterintuitive having a fullscreen prop, but at the same time always displaying fullscreen on mobile by default.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

@sandros94 sandros94 added the v3 #1289 label Nov 14, 2024
@sandros94 sandros94 self-assigned this Nov 14, 2024
Copy link

pkg-pr-new bot commented Nov 14, 2024 β€’

npm i https://pkg.pr.new/@nuxt/ui@2637

commit: 6f36ba5

@sandros94
Copy link
Member Author

I could also add top-auto bottom-0 translate-y-[-10%] to make it more on par with v2 styling

up
up
up
up
up
@benjamincanac benjamincanac merged commit 7641d89 into nuxt:v3 Feb 16, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] Modal always render fullscreen on mobile
2 participants