Skip to content

Commit 7641d89

Browse files
sandros94benjamincanac
andauthoredFeb 16, 2025··
fix(Modal): always fullscreen on mobile (#2637)
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
1 parent f55e869 commit 7641d89

File tree

5 files changed

+40
-40
lines changed

5 files changed

+40
-40
lines changed
 

‎playground/app/pages/components/modal.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ function openModal() {
5454
<UButton label="Open fullscreen" color="neutral" variant="outline" />
5555
</UModal>
5656

57-
<UModal title="Modal prevent close" description="This modal has `prevent-close: true` prop so it won't close when clicking outside." prevent-close>
57+
<UModal title="Modal prevent close" description="This modal has `dismissible: false` prop so it won't close when clicking outside." :dismissible="false">
5858
<UButton label="Open unclosable" color="neutral" variant="subtle" />
5959
</UModal>
6060

‎playground/app/pages/components/slideover.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ function openSlideover() {
9898
</template>
9999
</USlideover>
100100

101-
<USlideover title="Slideover prevent close" description="This slideover has `prevent-close: true` prop so it won't close when clicking outside." prevent-close>
101+
<USlideover title="Slideover prevent close" description="This slideover has `dismissible: false` prop so it won't close when clicking outside." :dismissible="false">
102102
<UButton label="Open unclosable" color="neutral" variant="subtle" />
103103

104104
<template #body>

‎src/theme/modal.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export default {
22
slots: {
33
overlay: 'fixed inset-0 bg-(--ui-bg-elevated)/75',
4-
content: 'fixed w-full h-dvh bg-(--ui-bg) divide-y divide-(--ui-border) flex flex-col focus:outline-none',
4+
content: 'fixed bg-(--ui-bg) divide-y divide-(--ui-border) flex flex-col focus:outline-none',
55
header: 'px-4 py-5 sm:px-6',
66
body: 'flex-1 overflow-y-auto p-4 sm:p-6',
77
footer: 'flex items-center gap-1.5 p-4 sm:px-6',
@@ -21,7 +21,7 @@ export default {
2121
content: 'inset-0'
2222
},
2323
false: {
24-
content: 'top-[50%] left-[50%] translate-x-[-50%] translate-y-[-50%] sm:max-w-lg sm:h-auto sm:max-h-[calc(100vh-4rem)] sm:rounded-[calc(var(--ui-radius)*2)] sm:shadow-lg sm:ring ring-(--ui-border)'
24+
content: 'top-1/2 left-1/2 -translate-x-1/2 -translate-y-1/2 w-[calc(100vw-2rem)] max-w-lg max-h-[calc(100vh-2rem)] sm:max-h-[calc(100vh-4rem)] rounded-[calc(var(--ui-radius)*2)] shadow-lg ring ring-(--ui-border)'
2525
}
2626
}
2727
}

‎test/components/__snapshots__/Modal-vue.spec.ts.snap

+18-18
Large diffs are not rendered by default.

‎test/components/__snapshots__/Modal.spec.ts.snap

+18-18
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)
Please sign in to comment.