Skip to content

chore: use tinyexec #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024
Merged

chore: use tinyexec #939

merged 2 commits into from
Sep 10, 2024

Conversation

BobbieGoede
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Same as nuxt/nuxt#28684

Tried tinyexec in the test-utils 'fork' used in the i18n module, besides reducing dependencies it seems to perform better than execa when running with CI=1 (based on very basic & lazy testing).

Sorry, something went wrong.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@BobbieGoede
Copy link
Member Author

I also raised the timeouts for windows browser tests, while it may be slower at least we can be sure that the tests succeed.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ⚑

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
@danielroe danielroe merged commit 4bd549f into nuxt:main Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants