Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtim-utils): do not use defu for merging #1089

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Jan 22, 2025

πŸ”— Linked issue

ref: #1078

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

There were cases where setProps could not overwrite when defu was used.
Therefore, the merging of props will no longer use defu.

Sorry, something went wrong.

@wattanx wattanx marked this pull request as ready for review January 22, 2025 13:49
@wattanx wattanx requested a review from danielroe as a code owner January 22, 2025 13:49
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❀️

@danielroe danielroe merged commit 76c92a4 into main Jan 24, 2025
4 checks passed
@danielroe danielroe deleted the fix/fix-merge branch January 24, 2025 14:30
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
@sebbayer
Copy link

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants