Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use simple inlined noop instead of unenv #420

Merged
merged 2 commits into from
Mar 9, 2025
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

this helps avoid issues with hoisting on unenv

Sorry, something went wrong.

@danielroe danielroe requested a review from harlan-zw March 8, 2025 23:20
Copy link

vercel bot commented Mar 8, 2025 β€’

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
scripts-docs ❌ Failed (Inspect) Mar 8, 2025 11:32pm
scripts-playground ❌ Failed (Inspect) Mar 8, 2025 11:32pm

@danielroe danielroe changed the title fix: move from unenv to mocked-exports fix: use simple inlined noop instead of unenv Mar 8, 2025
@harlan-zw
Copy link
Collaborator

Thanks!

@harlan-zw harlan-zw merged commit 294bfe2 into main Mar 9, 2025
5 of 7 checks passed
@harlan-zw harlan-zw deleted the fix/mocked-exports branch March 9, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants