fix(nuxt): don't add macro query to the end of id #5413
Conversation
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
As a workaround, this seems good to me, but also see https://github.com/vitejs/vite/issues/8473#issuecomment-1152880131.
| @@ -46,7 +46,8 @@ export const TransformMacroPlugin = createUnplugin((options: TransformMacroPlugi | |||
| // with workaround for vue-loader bug: https://github.com/vuejs/vue-loader/pull/1911 | |||
| const scriptImport = findStaticImports(code).find(i => parseQuery(i.specifier.replace('?macro=true', '')).type === 'script') | |||
| if (scriptImport) { | |||
| const specifier = withQuery(scriptImport.specifier.replace('?macro=true', ''), { macro: 'true' }) | |||
There was a problem hiding this comment.
withQuery doesn't changes the order by default if we didn't first remove ?macro=true. /cc @danielroe Was there any reason you used replaced initially?
There was a problem hiding this comment.
Ah, very good point. It was to work around another vite issue, where any existing query was not respected. (So id that vite produced was something like ?macro=true?lang=test.jsx.)
There was a problem hiding this comment.
Thanks for explaining. Does the issue exists anymore?
There was a problem hiding this comment.
Ah, I see I was wrong - it was a vue-loader bug: vuejs/vue-loader#1911 which still exists with an open PR to fix it. I'll need to check that this PR doesn't introduce a regression with webpack.
🔗 Linked issue
Resolves vitejs/vite#3488
❓ Type of change
📚 Description
The query
lang.jsxof id should be at the end of id, according to vitejs/vite-plugin-vue#23However
¯o=trueis added at the end so that thelangquery is not parsed expectedly in vite plugins.📝 Checklist