Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scan font families declared in font: #299

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

qwerzl
Copy link
Member

@qwerzl qwerzl commented Oct 1, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

@danielroe

Resolves #291. css-tree does the parsing work automatically for us.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe
@qwerzl qwerzl requested a review from danielroe as a code owner October 1, 2024 01:43
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024 β€’

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.98%. Comparing base (9119228) to head (9c49caa).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
playground/pages/providers/google.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   41.98%   41.98%           
=======================================
  Files          58       58           
  Lines        3561     3561           
  Branches      442      442           
=======================================
  Hits         1495     1495           
  Misses       2028     2028           
  Partials       38       38           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe changed the title fix: support scanning font families from "font:" fix: scan font families declared in font: Oct 1, 2024
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as always, thank you ❀️

@danielroe danielroe merged commit 8bf72cd into nuxt:main Oct 1, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
@qwerzl qwerzl deleted the feat/scanning-font branch October 1, 2024 15:39
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support scanning font families from "font:"
3 participants