Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): respect explicit address and port in --inspect #508

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

G3z
Copy link
Contributor

@G3z G3z commented Oct 10, 2024 β€’

πŸ”— Linked issue

Resolves #403

❓ Type of change

respect the --inspect argument that is passed to nuxi dev

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It's not easy to attach the debugger to a nuxt running in docker beacuse --inspect is passed without host (typically 0.0.0.0) and port.
it now passes the argument as it's passed by the user

Typical values could be

  • nuxi dev --inspect
  • nuxi dev --inspect=0.0.0.0
  • nuxi dev --inspect=9229
  • nuxi dev --inspect=0.0.0.0:9229

at the moment only the first option works but all the other are supported (just filtered out)

Sorry, something went wrong.

@G3z G3z requested a review from danielroe as a code owner October 10, 2024 09:35
G3z and others added 2 commits October 10, 2024 11:42
@danielroe danielroe changed the title respect the addredd and port sent to --inspect fix(dev): respect explicit address and port in --inspect Oct 15, 2024
@danielroe danielroe merged commit b8873ed into nuxt:main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to pass host und port arguments for --inspect for nuxi dev
2 participants