Use PHPUnit 10 for testing

[spawnia]

No description provided.

[spawnia]

The remaining issue is this:

Failed asserting that exception of type "Illuminate\Contracts\Container\BindingResolutionException" matches expected exception "Nuwave\Lighthouse\Exceptions\DefinitionException". Message was: "Unresolvable dependency resolving [Parameter #0 [ <required> string $name ]] in class PHPUnit\Framework\TestCase" at
/home/runner/work/lighthouse/lighthouse/vendor/laravel/framework/src/Illuminate/Container/Container.php:1143
...
/home/runner/work/lighthouse/lighthouse/tests/Integration/Schema/Types/UnionTest.php:170

Essentially, the problem lies within the use of $this->qualifyTestResolver() - whereas PHPUnit\Framework\TestCase required no constructor arguments prior to PHPUnit 10, it now needs one - meaning the container cannot instantiate it. The only solution I can think of is to move the test resolvers to separate files, which will complicate things a bit.

[pyrou]

The remaining issue is this:

Failed asserting that exception of type "Illuminate\Contracts\Container\BindingResolutionException" matches expected exception "Nuwave\Lighthouse\Exceptions\DefinitionException". Message was: "Unresolvable dependency resolving [Parameter #0 [ <required> string $name ]] in class PHPUnit\Framework\TestCase" at
/home/runner/work/lighthouse/lighthouse/vendor/laravel/framework/src/Illuminate/Container/Container.php:1143
...
/home/runner/work/lighthouse/lighthouse/tests/Integration/Schema/Types/UnionTest.php:170

Essentially, the problem lies within the use of $this->qualifyTestResolver() - whereas PHPUnit\Framework\TestCase required no constructor arguments prior to PHPUnit 10, it now needs one - meaning the container cannot instantiate it. The only solution I can think of is to move the test resolvers to separate files, which will complicate things a bit.

This is a possible (dirty) workaround

https://laravel.com/docs/10.x/container#binding-primitives

$this->app->when(TestCase::class)
          ->needs('$name')
          ->give("TestName");

[spawnia]

Thanks @pyrou, unfortunately I could not get it to work. Could you check out the branch and see if you can make it work?

[pyrou]

Looks like because its called to early. Somehow it is reset somewhere

When moving code in TestCase::setUp() it works fine

// tests/TestCase.php
protected function setUp(): void
{
    parent::setUp();

    // This default is only valid for testing Lighthouse itself and thus
    // is not defined in the reusable test trait.
    $this->schema ??= self::PLACEHOLDER_QUERY;
    $this->setUpTestSchema();

    $this->app->when($this::class)
        ->needs('$name')
        ->give('TestName');

}

[spawnia]

Using $this was the key - I switched to static though, now it works fine.