Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unexpected spaces after large buffer input #783

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

sigoden
Copy link
Contributor

@sigoden sigoden commented Apr 22, 2024

This issue also appears in the latest version of NuShell.

reedline01.mp4

close #703

@fdncred
Copy link
Collaborator

fdncred commented Apr 23, 2024

Is there a good way to add a test for this to ensure we don't break it in the future?

@sigoden
Copy link
Contributor Author

sigoden commented Apr 23, 2024

Painter mainly interacts with the terminal and is not easy to unit test.
There are not many relevant .tests even in crossterm.

@fdncred fdncred merged commit 4cf8c75 into nushell:main Apr 24, 2024
6 checks passed
@sigoden sigoden deleted the fix-294 branch April 24, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected spaces between the end of a pasted multiline string and reply
2 participants