-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ide menu not reporting correct required_lines #781
Conversation
@maxomatic458 I am no longer seeing an issue with nushell and reedline in the latest nushell main... when I type "str" on my mac in a ghostty terminal it all looks good... I am not seeing what this issue is reporting #753 Everything looks fine to me... |
@stormasm it only happens when
can you replicate it with this config? |
see my config below... I changed it to 5 but for the str example I am still seeing the exact same thing as before... menus: [
# Configuration for default nushell menus
# Note the lack of source parameter
{
name: completion_menu
only_buffer_difference: false
marker: "| "
type: {
layout: columnar
columns: 4
col_width: 20 # Optional value. If missing all the screen width is used to calculate column width
col_padding: 2
max_completion_height: 5
}
style: {
text: green
selected_text: { attr: r }
description_text: yellow
match_text: { attr: u }
selected_match_text: { attr: ur }
}
}
{
name: ide_completion_menu
only_buffer_difference: false
marker: "| "
type: {
layout: ide
min_completion_width: 0,
max_completion_width: 50,
max_completion_height: 5, # will be limited by the available lines in the terminal
padding: 0,
border: true,
cursor_offset: 0,
description_mode: "prefer_right"
min_description_width: 0
max_description_width: 50
max_description_height: 10
description_offset: 1
# If true, the cursor pos will be corrected, so the suggestions match up with the typed text
#
# C:\> str
# str join
# str trim
# str split
correct_cursor_pos: false
} |
maxomatic-01.mov |
So I guess the max_completion_height is not kicking in either as I am seeing more than 5 ? |
hold on my layout is columnar instead of ide let me change it... |
also to see the bug |
@maxomatic458 I was finally able to reproduce the bug 😄 And your code indeed fixes it !! |
Also one other thing @maxomatic458 |
nushell/reedline#781 This will allow others to test and make sure that this reedline fix works on other terminals and platforms...
closes #753