Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a constructor with configuration structure #143

Merged
merged 1 commit into from Mar 18, 2024

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Mar 18, 2024

Description

Add a constructor with a configuration structure.

Simplify the integration inside golangci-lint.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added test case and related test data
  • Update the functional test

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran golangci-lint

@nunnatsa

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8328779049

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 64.396%

Totals Coverage Status
Change from base Build 8325253645: 0.4%
Covered Lines: 208
Relevant Lines: 323

💛 - Coveralls

@nunnatsa
Copy link
Owner

Thanks @ldez

LGTM

@nunnatsa nunnatsa merged commit 97de4a9 into nunnatsa:main Mar 18, 2024
1 check passed
@ldez ldez deleted the feat/constructor-config branch March 18, 2024 16:01
@nunnatsa
Copy link
Owner

@ldez - version v0.16.1 was released with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants