FIX: coroutines can have a return statement #542
Conversation
The value returned by the coroutine is carried on the `StopIteration` Exception that is raised when exhausted.
tacaswell
force-pushed
the
fix/coros_can_return
branch
from
af76b3a
to
988af7f
Compare
tacaswell
force-pushed
the
fix/coros_can_return
branch
from
988af7f
to
fb17eb1
Compare
|
I do not understand why the 3.8 test works on main (as |
There was a problem hiding this comment.
The changes themselves LGTM, thanks @tacaswell
Re: the sphinx pinning - running locally I get 5 sphinx.errors.ExtensionError related to overwrite_pygments_css. Is this what motivated the pinning for you @tacaswell ? It seems this is a known issue (sphinx-doc/sphinx#12299) which should be fixed in 7.3.7 - +1 from me for temporary pins until the sphinx 7.3 smoke clears.
|
Yes, I was seeing a handful of errors from sphinx (I did not dig too deep) but given the amount of other smoke from sphinx 7.3 (and that tests passed on main with 7.2.6) I took a guess and pinned back. |
|
@jarrodmillman this one is ready to go but I'm not sure what's going on with the CI status. I tried to merge but the only thing it allows is "enabling" merging once these jobs finish. I'm happy to go in and fixup the CI to disallow this but I don't to meddle if it might be violating some policy. Personally I'd be in favor of removing the "Required" tag on these jobs, especially since the dependencies can get quite complicated for numpydoc's support windows. |
|
oh, I see what happened...the version pinning changed the job name which changed to miss the rules... |
The value returned by the coroutine is carried on the
StopIterationException that is raised when exhausted.This is a follow up to #145 which allows documenting. This came up in the discussions then (#47 (comment)), but I missed that it was forbidden!