BUG: fix race initializing legacy dtype casts #28321
Merged
+438
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
added
00 - Bug
08 - Backport
- Checkout numpy/testing/_private/utils.py - Checkout numpy/_core/tests/test_multithreading.py - Checkout conftest.py - Update test_requirements.txt
charris
force-pushed
the
backport-28290
branch
from
8cc21e2 to
48515a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #28290.
Fixes #28048
Locks
castingimplswith a critical section when thecastingimplscache is empty before writing to the dict.Because the critical section macros have braces, I refactored
PyArray_GetCastingImplinto three functions that call each other. Only the "middle" function needs the critical section, so that reduces the pain of not being able to early return in a critical section a little bit.I also added some comments because this took me quite a while to fully understand so future readers will hopefully be less confused.
Edit: there are also some unrelated fixes for the test infrastructure to avoid CI crashes and generate better debug output from CI jobs. Happy to do those separately if anyone requests.