Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: pin cygwin python to 3.9.16-1 and fix typing tests [skip cirrus][skip azp][skip circle] #25718

Merged
merged 2 commits into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/cygwin.yml
Expand Up @@ -25,15 +25,16 @@ jobs:
submodules: recursive
fetch-depth: 0
- name: Install Cygwin
uses: cygwin/cygwin-install-action@006ad0b0946ca6d0a3ea2d4437677fa767392401 # v4
uses: egor-tensin/setup-cygwin@d2c752bab416d4b0662591bd366fc2686297c82d #v4
with:
platform: x86_64
install-dir: 'C:\tools\cygwin'
packages: >-
python39-devel python39-pip python-pip-wheel python-setuptools-wheel
liblapack-devel liblapack0 gcc-fortran gcc-g++ git dash cmake ninja
python39=3.9.16-1 python39-devel=3.9.16-1 python39-pip python-pip-wheel
python-setuptools-wheel liblapack-devel liblapack0 gcc-fortran
gcc-g++ git dash cmake ninja
- name: Set Windows PATH
uses: egor-tensin/cleanup-path@8469525c8ee3eddabbd3487658621a6235b3c581 # v3
uses: egor-tensin/cleanup-path@f04bc953e6823bf491cc0bdcff959c630db1b458 # v4.0.1
with:
dirs: 'C:\tools\cygwin\bin;C:\tools\cygwin\lib\lapack'
- name: Verify that bash is Cygwin bash
Expand Down Expand Up @@ -63,7 +64,7 @@ jobs:
cd tools
/usr/bin/python3.9 -m pytest --pyargs numpy -n2 -m "not slow"
- name: Upload wheel if tests fail
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
if: failure()
with:
name: numpy-cygwin-wheel
Expand Down
2 changes: 0 additions & 2 deletions numpy/typing/tests/test_typing.py
Expand Up @@ -86,8 +86,6 @@ def strip_func(match: re.Match[str]) -> str:
return match.groups()[1]


@pytest.mark.slow
@pytest.mark.skipif(NO_MYPY, reason="Mypy is not installed")
@pytest.fixture(scope="module", autouse=True)
def run_mypy() -> None:
"""Clears the cache and run mypy before running any of the typing tests.
Expand Down