Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Add missing noexcept to shuffle helpers #25115

Merged
merged 1 commit into from
Nov 11, 2023
Merged

MAINT: Add missing noexcept to shuffle helpers #25115

merged 1 commit into from
Nov 11, 2023

Commits on Nov 11, 2023

  1. MAINT: Add missing noexcept to shuffle helpers 

    These shouldn't fail and should work without the GIL, but as cython
points out (now), this doesn't work in practice, because without
the `noexcept`, cython will grab the GIL to check for errors every
time.
    @seberg @charris
    seberg authored and charris committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    c2f0c44 View commit details
    Browse the repository at this point in the history