Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Backport fix build on ppc64 when the baseline set to Power9 or higher #25083

Merged
merged 1 commit into from Nov 7, 2023

Conversation

seiko2plus
Copy link
Member

@seiko2plus seiko2plus commented Nov 7, 2023

Backport #24806

closes #24789

  This fix addresses two issues:
   * Corrects the use of unsupported instructions by the assembler
     in half-precision to double-precision conversion.
   * Resolves a code error related to variable naming during conversion.

  It also:
   * Implement a compile-time test on PPC64 to determine support for Half/Double
     VSX3 instructions by the assembler
   * Modify half-precision tests to deal with FP HW exceptions
@seiko2plus seiko2plus added the 08 - Backport Used to tag backport PRs label Nov 7, 2023
@mattip
Copy link
Member

mattip commented Nov 7, 2023

Copying the comment from #24789:

Works for me here on POWER9, both LE and BE. Thanks!

@charris charris merged commit 55d3f26 into numpy:maintenance/1.26.x Nov 7, 2023
50 of 52 checks passed
@charris
Copy link
Member

charris commented Nov 7, 2023

Thanks Sayed.

@yselkowitz
Copy link

Is there a timeline for the next 1.26.x release with this fix?

@charris
Copy link
Member

charris commented Nov 7, 2023

Is there a timeline for the next 1.26.x release with this fix?

Somewhere between a week and two weeks from now.

charris added a commit to charris/numpy that referenced this pull request Nov 11, 2023
Backport of numpy#24806.

This backport was already made in numpy#25083, but that didn't make
use of the linux_qemu.yml action, so this tweaks it a bit.
charris added a commit to charris/numpy that referenced this pull request Nov 11, 2023
Backport of numpy#24806.

This backport was already made in numpy#25083, but that didn't make
use of the linux_qemu.yml action, so this tweaks it a bit.
charris added a commit to charris/numpy that referenced this pull request Nov 11, 2023
Backport of numpy#24806.

This backport was already made in numpy#25083, but that didn't make
use of the linux_qemu.yml action, so this tweaks it a bit.
charris added a commit to charris/numpy that referenced this pull request Nov 11, 2023
Backport of numpy#24806.

This backport was already made in numpy#25083, but that didn't make
use of the linux_qemu.yml action, so this tweaks it a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
00 - Bug 08 - Backport Used to tag backport PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants