Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Split up .github/workflows to match main #25071

Merged
merged 4 commits into from Nov 6, 2023

Conversation

charris
Copy link
Member

@charris charris commented Nov 5, 2023

This is a backport of #24493, #24291, and #24625. The purpose of this is to ease future
backports that expect these files.

  • CI: move some jobs in build_test.yml to Meson

  • CI: split build_test.yml into three GHA jobs files

    Also documents better what is being run. See Restructuring GitHub Actions CI jobs #24410 for the
    overall restructuring plan for GitHub Actions CI.

  • CI: merge linux_meson.yml into linux_blas.yml

  • TST: disable mypy tests in test suite unless an environment variable is set

    These tests are super slow, and they're effectively always passing in CI.
    Running them on all "full" test suite runs is too expensive. Note that
    SciPy has an XSLOW mark, NumPy does not. So use an env var for now.

  • CI: add new GHA CI jobs to run MyPy across OS/Python flavors

This is a backport of numpy#24493 and numpy#24291. The purpose of
this is to ease future backports that expect these files.

- CI: move some jobs in `build_test.yml` to Meson

- CI: split `build_test.yml` into three GHA jobs files

  Also documents better what is being run. See numpygh-24410 for the
  overall restructuring plan for GitHub Actions CI.

- CI: merge `linux_meson.yml` into `linux_blas.yml`

- TST: disable mypy tests in test suite unless an environment variable is set

  These tests are super slow, and they're effectively always passing in CI.
  Running them on all "full" test suite runs is too expensive. Note that
  SciPy has an XSLOW mark, NumPy does not. So use an env var for now.

- CI: add new GHA CI jobs to run MyPy across OS/Python flavors
@charris charris added 03 - Maintenance 08 - Backport Used to tag backport PRs labels Nov 5, 2023
@charris charris added this to the 1.26.2 release milestone Nov 5, 2023
typing_nptensions -> typing_extensions
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful indeed, thanks Chuck. LGTM modulo a few stray merge conflict markers.

.github/workflows/linux_simd.yml Outdated Show resolved Hide resolved
.github/workflows/linux_simd.yml Outdated Show resolved Hide resolved
.github/workflows/linux_simd.yml Outdated Show resolved Hide resolved
.github/workflows/linux_simd.yml Outdated Show resolved Hide resolved
.github/workflows/linux_simd.yml Outdated Show resolved Hide resolved
@charris charris force-pushed the backport-24291-24493 branch 3 times, most recently from dd92367 to f7d47f9 Compare November 6, 2023 02:07
@charris
Copy link
Member Author

charris commented Nov 6, 2023

The Linux SIMD test is failing for Python 3.12, I currently have it commented out.

@rgommers
Copy link
Member

rgommers commented Nov 6, 2023

The Linux SIMD test is failing for Python 3.12, I currently have it commented out.

Perhaps easier to debug separately? This is green and looks safe to merge. I'm happy to have a look at the failure after this gets merged.

@charris
Copy link
Member Author

charris commented Nov 6, 2023

This is green and looks safe to merge.

Let's do that. Trying to wring information from the meson log isn't easy.

@charris charris merged commit 7387600 into numpy:maintenance/1.26.x Nov 6, 2023
49 checks passed
@charris charris deleted the backport-24291-24493 branch November 6, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants