Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: use classic linker on macOS, the new one in XCode 15 has issues #24977

Merged
merged 2 commits into from
Oct 21, 2023
Merged

BLD: use classic linker on macOS, the new one in XCode 15 has issues #24977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b1ce1
BLD: use classic linker on macOS, the new one in XCode 15 has issues
rgommers Oct 20, 2023
b93e52e
BLD: only check for scipy-openblas dependency with pkg-config
rgommers Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,5 +82,11 @@ if cc_id.startswith('clang')
endif
endif

if host_machine.system() == 'darwin' and cc.has_link_argument('-Wl,-ld_classic')
# New linker introduced in macOS 14 not working yet with at least OpenBLAS in Spack,
# see gh-24964 (and linked scipy issue from there).
add_project_link_arguments('-Wl,-ld_classic', language : ['c', 'cpp'])
endif

subdir('meson_cpu')
subdir('numpy')
2 changes: 1 addition & 1 deletion numpy/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ mkl_may_use_sdl = not use_ilp64 and _threading_opt in ['auto', 'iomp']
# First try scipy-openblas, and if found don't look for cblas or lapack, we
# know what's inside the scipy-openblas wheels already.
if blas_name == 'openblas' or blas_name == 'auto'
blas = dependency('scipy-openblas', required: false)
blas = dependency('scipy-openblas', method: 'pkg-config', required: false)
if blas.found()
blas_name = 'scipy-openblas'
endif
Expand Down