Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: unpin sphinx #24516

Merged
merged 2 commits into from
Aug 24, 2023
Merged

DOC: unpin sphinx #24516

merged 2 commits into from
Aug 24, 2023

Conversation

mattip
Copy link
Member

@mattip mattip commented Aug 24, 2023

Reverts #24439 now that sphinx 7.2.3 with a fix was released.

Related to #24438
cc @AA-Turner

@mattip mattip changed the title DOC: unpin sphinx [skip cirrus] [skip azp] [skip travis] [skip actions] DOC: unpin sphinx Aug 24, 2023
@mattip
Copy link
Member Author

mattip commented Aug 24, 2023

The doc build gets further, but now we get a ThemeError

sphinx.errors.ThemeError: An error happened in rendering the page dev/internals.code-explanations.
Reason: ThemeError("Local asset file paths must not contain query strings: '_static/scipy-mathjax/MathJax.js?config=scipy-mathjax'")

This is coming from the numpy conf.py:

mathjax_path = "scipy-mathjax/MathJax.js?config=scipy-mathjax"

I think the query string is unused, let's see if math rendering breaks when I remove it.

@charris charris merged commit 2890183 into numpy:main Aug 24, 2023
4 checks passed
@charris
Copy link
Member

charris commented Aug 24, 2023

Thanks Matti, let's give it a shot.

@AA-Turner
Copy link

Thanks Matti, please let me know if you run into any further issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants