Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Move export for scipy arm64 helper into main module #22972

Merged
merged 2 commits into from Jan 9, 2023
Merged

MAINT: Move export for scipy arm64 helper into main module #22972

merged 2 commits into from Jan 9, 2023

Commits on Jan 9, 2023

  1. MAINT: Move export for scipy arm64 helper into main module 

    This is a follow up to numpygh-22679 which addressed numpygh-22673.

The main thing is that we want the functions to be available after
importing NumPy, so they need to be part of multiarray.
However, `npymath` is a static library, so the symbols are not really
exported there.  The former PR did actually work in practice but this
seems like it is technically the right place?

For some reason, I had to add nextafter to be able to do:

    from scipy.spatial.distance import euclidean

with the SciPy 1.9.3 wheels.  SciPy test collection works with this for
the 1.9.3 wheel, so this should be all the symbols hopefully.
    @seberg @charris
    seberg authored and charris committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    8d6d4aa View commit details
    Browse the repository at this point in the history

  2. restore declaration of npy_nextafter

    @mattip
    mattip committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    118a01a View commit details
    Browse the repository at this point in the history