Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix fill violating read-only flag. #22959

Merged
merged 4 commits into from Jan 8, 2023
Merged

BUG: Fix fill violating read-only flag. #22959

merged 4 commits into from Jan 8, 2023

Commits on Jan 7, 2023

  1. Bug: Fix fill violating read-only flag. 

    - See numpy#22922
- `PyArray_FillWithScalar` checks if destination is writeable before
  attempting to fill it
- A relevant test is added as a method of `TestRegression`
    @panosz
    panosz committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    115bca2 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2023

  1. MAINT: Fix comment in PyArray_FillWithScalar. Move test to new location. 

    -- The comment in `PyArray_FillWithScalar` is about the code after the
readonly check, so it was moved to the appropriate location.
-- The `test_fill_readonly` was moved to test_multiarray.TestAttributes.
    @panosz
    panosz committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    6cac473 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @seberg
    seberg committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    39200d8 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @seberg
    seberg committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    a3136b5 View commit details
    Browse the repository at this point in the history