Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactoring guesses package #153

Merged
merged 8 commits into from Aug 23, 2023
Merged

Conversation

vvatanabe
Copy link
Member

  • optimized pattern matching in uppercaseVariations and reduced lowercaseToken generation in l33tVariations of DictionaryGuess
  • clarified exec logic, removed unnecessary else, and improved readability with early returns in RegexGuess
  • replaced switch with map lookup, extracted guess initialization, and reduced nesting with early returns in EstimateGuess
  • optimized START_POINTS lookup with Set, cached regex pattern, and improved code readability in SequenceGuess
  • split the logic inside the exec method of SpatialGuess into two new private methods
  • split the logic inside the exec method of DateGuess into two new private methods
  • split the logic inside the exec method of BruteforceGuess into two new private methods
  • add brackets to the if statement in BaseGuess

@vvatanabe vvatanabe merged commit 5cc26d3 into main Aug 23, 2023
2 checks passed
@vvatanabe vvatanabe deleted the refactoring-guesses-pkg branch August 25, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant