Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEOS-1774 Update Mysql Init Schema to drop constraints and columns #3378

Merged
merged 36 commits into from
Mar 17, 2025
Merged

NEOS-1774 Update Mysql Init Schema to drop constraints and columns #3378

merged 36 commits into from
Mar 17, 2025
+1,991 −94

Conversation

alishakawaguchi
Copy link
Contributor

No description provided.

@alishakawaguchi
schema manager builder

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e475776
@alishakawaguchi
move init schema to own workflow

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
99a849f
@alishakawaguchi
fix tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
82a5f32
@alishakawaguchi
clean up

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
57b082b
@alishakawaguchi
Merge branch 'main' into alisha/neos-1774-mysql-schema-updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
9f62a21
@alishakawaguchi
update init schema workflow to be destination specific

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
26198cf
@alishakawaguchi
fix tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
d2e793c
@alishakawaguchi
schema diff

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f046614
@alishakawaguchi
fix tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
7777220
@alishakawaguchi
fix workflow id

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
fa30f9a
@alishakawaguchi
Merge branch 'alisha/neos-1774-mysql-schema-updates' into alisha/neos…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e16e1b6 
…-1774-columns
@alishakawaguchi
schema diff tables and columns

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2f6bd59
@alishakawaguchi
reconcile schema activity

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4a88874
@alishakawaguchi
fix init schema errors runcontext workflow id

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
279476b
@alishakawaguchi
Merge branch 'alisha/neos-1774-mysql-schema-updates' into alisha/neos…
79928db 
…-1774-columns
@alishakawaguchi
new activity
9e17eba
@alishakawaguchi
new truncate function
75d240f
@alishakawaguchi
Merge branch 'main' into alisha/neos-1774-columns
Loading
Loading status checks…
4824cb5
@alishakawaguchi
integration test
28df675
@alishakawaguchi
Merge branch 'main' into alisha/neos-1774-columns
9015c71
@alishakawaguchi
stash
Loading
Loading status checks…
a6a8d37
@alishakawaguchi
fix update processor
Loading
Loading status checks…
cee391e
@alishakawaguchi
Merge branch 'alisha/fix-processors' into alisha/neos-1774-columns
bbfff3a
@alishakawaguchi
Merge branch 'main' into alisha/neos-1774-columns
26ec0ef
@alishakawaguchi
remove prints
b93456a
@alishakawaguchi
stash
197fd26
@alishakawaguchi
fix on conflict update with generated columns
Loading
Loading status checks…
34e489c
@alishakawaguchi
Merge branch 'main' into alisha/neos-1774-columns
Loading
Loading status checks…
0237313
@alishakawaguchi
stash
e2ce660
@alishakawaguchi
Merge branch 'main' into alisha/neos-1774-drop
f1602b1
@alishakawaguchi
drop constraints and columns
Loading
Loading status checks…
9f8306f
@alishakawaguchi
working
a502aa5
@alishakawaguchi
unit tests
Loading
Loading status checks…
6ec4cd6
@alishakawaguchi alishakawaguchi added the enhancement New feature or request label Mar 17, 2025
@alishakawaguchi alishakawaguchi self-assigned this Mar 17, 2025
@linear Linear
Copy link

linear bot commented Mar 17, 2025

NEOS-1774 Mysql incremental schema update

@vercel Vercel
Copy link

vercel bot commented Mar 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Mar 17, 2025 9:53pm

@codecov Codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.26316% with 187 lines in your changes missing coverage. Please review.

Project coverage is 24.23%. Comparing base (8bf8bc9) to head (439be80).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/schema-manager/mysql/mysql.go 0.00% 92 Missing ⚠️
backend/pkg/sqlmanager/mysql/mysql-manager.go 0.00% 80 Missing ⚠️
internal/schema-manager/shared/schema-diff.go 88.88% 6 Missing and 5 partials ⚠️
backend/pkg/sqlmanager/mssql/mssql-manager.go 0.00% 2 Missing ⚠️
...ackend/pkg/sqlmanager/postgres/postgres-manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3378      +/-   ##
==========================================
+ Coverage   23.94%   24.23%   +0.29%     
==========================================
  Files         411      414       +3     
  Lines       47953    48340     +387     
==========================================
+ Hits        11480    11713     +233     
- Misses      35357    35507     +150     
- Partials     1116     1120       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 17, 2025 •
edited
Loading

Benchstat Geomean Results

-1.25% sec/op, -0.03% B/op, 0.97% allocs/op

Benchstat results 
                                   │ main-benchmark.txt │        branch-benchmark.txt         │
                                   │       sec/op       │    sec/op     vs base               │
CleanPostgresType-4                         42.63n ± 4%    44.26n ± 2%   +3.82% (p=0.013 n=6)
Runner_Single-4                             7.713µ ± 5%    7.733µ ± 2%        ~ (p=0.589 n=6)
GenerateBool-4                              11.45n ± 1%    11.38n ± 5%        ~ (p=0.461 n=6)
GenerateBusinessName-4                      285.4n ± 0%    327.1n ± 2%  +14.59% (p=0.002 n=6)
GenerateCardNumber-4                        28.41n ± 1%    27.46n ± 0%   -3.34% (p=0.002 n=6)
GenerateCategorical-4                      104.10n ± 2%    97.03n ± 0%   -6.80% (p=0.002 n=6)
GenerateCity-4                              173.7n ± 0%    180.5n ± 1%   +3.91% (p=0.002 n=6)
GenerateCountry-4                          105.20n ± 1%    96.01n ± 0%   -8.74% (p=0.002 n=6)
GenerateEmail-4                             1.346µ ± 0%    1.320µ ± 1%   -1.93% (p=0.002 n=6)
GenerateFirstName-4                         203.9n ± 0%    207.2n ± 1%   +1.64% (p=0.002 n=6)
GenerateFloat64-4                           28.73n ± 1%    26.46n ± 0%   -7.90% (p=0.002 n=6)
GenerateFullAddress-4                       1.429µ ± 3%    1.433µ ± 1%        ~ (p=0.721 n=6)
GenerateFullName-4                          1.222µ ± 1%    1.315µ ± 2%   +7.65% (p=0.002 n=6)
GenerateGender-4                            41.42n ± 0%    37.42n ± 1%   -9.67% (p=0.002 n=6)
GenerateInt64-4                             28.41n ± 2%    26.71n ± 0%   -5.95% (p=0.002 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%    50.87n ± 0%   -1.15% (p=0.002 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%    169.8n ± 1%   -3.41% (p=0.002 n=6)
GenerateIpAddress-4                         569.3n ± 0%    549.8n ± 1%   -3.42% (p=0.002 n=6)
GenerateLastName-4                          187.4n ± 1%    202.0n ± 1%   +7.76% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   1030.0n ± 0%   +4.50% (p=0.002 n=6)
GenerateSHA256Hash-4                        1.016µ ± 0%    1.005µ ± 1%   -1.13% (p=0.004 n=6)
GenerateSSN-4                               305.8n ± 1%    281.8n ± 1%   -7.83% (p=0.002 n=6)
GenerateState-4                            105.15n ± 2%    95.56n ± 1%   -9.13% (p=0.002 n=6)
GenerateStreetAddress-4                     204.0n ± 1%    213.3n ± 1%   +4.58% (p=0.002 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%    165.3n ± 1%   -7.78% (p=0.002 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%    77.24n ± 0%        ~ (p=0.965 n=6)
GenerateUsername-4                          351.5n ± 0%    374.2n ± 3%   +6.46% (p=0.002 n=6)
GenerateUTCTimestamp-4                      104.2n ± 1%    103.9n ± 2%        ~ (p=0.307 n=6)
GenerateUUID-4                              734.0n ± 0%    733.9n ± 0%        ~ (p=0.619 n=6)
GenerateZipcode-4                          105.15n ± 2%    94.33n ± 2%  -10.29% (p=0.002 n=6)
TransformCharacterScramble-4                171.8n ± 1%    164.8n ± 1%   -4.05% (p=0.002 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%    173.6n ± 1%   -3.66% (p=0.002 n=6)
TransformEmail-4                            1.798µ ± 2%    1.767µ ± 0%   -1.72% (p=0.002 n=6)
TransformFirstName-4                        233.9n ± 0%    258.9n ± 3%  +10.69% (p=0.002 n=6)
TransformFloat64-4                          110.8n ± 4%    101.5n ± 1%   -8.43% (p=0.002 n=6)
TransformFullName-4                         1.235µ ± 2%    1.312µ ± 1%   +6.24% (p=0.002 n=6)
TransformInt64-4                            33.74n ± 1%    31.68n ± 1%   -6.12% (p=0.002 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%    61.32n ± 0%   +6.03% (p=0.002 n=6)
TransformLastName-4                         191.6n ± 0%    204.3n ± 2%   +6.63% (p=0.002 n=6)
TransformString-4                           1.022µ ± 0%    1.058µ ± 3%   +3.42% (p=0.002 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%    188.9n ± 1%  -10.45% (p=0.002 n=6)
TransformUuid-4                             36.54n ± 1%    33.26n ± 1%   -8.98% (p=0.002 n=6)
geomean                                     194.0n         191.6n        -1.25%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.286Ki ± 2%  -1.16% (p=0.015 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 0%       ~ (p=0.455 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.03%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │        branch-benchmark.txt         │
                                   │     allocs/op      │ allocs/op   vs base                 │
CleanPostgresType-4                        0.000 ± 0%     0.000 ± 0%        ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ± 0%        ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ± 0%        ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ± 0%        ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ± 0%        ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     3.000 ± 0%  +50.00% (p=0.002 n=6)
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ± 0%        ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ± 0%        ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ± 0%        ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ± 0%        ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ± 0%        ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ± 0%        ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ± 0%        ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ± 0%        ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=6) ¹
geomean                                               ²                +0.97%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@alishakawaguchi
clean up
Loading
Loading status checks…
687d249
@alishakawaguchi
clean up
Loading
Loading status checks…
439be80
nickzelei
nickzelei approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@nickzelei nickzelei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alishakawaguchi alishakawaguchi merged commit 926bf7a into main Mar 17, 2025
15 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/neos-1774-drop branch March 17, 2025 23:02
@BrewTestBot BrewTestBot mentioned this pull request Mar 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickzelei nickzelei

Assignees

@alishakawaguchi alishakawaguchi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alishakawaguchi @nickzelei