Workaround for fixing GitHub runners on macOS #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub switched "macos-latest" from "macos-12" to "macos-14", which is only on ARM64! actions/runner#3256 https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ However we are having some issues build nDPI on macos-14 with external libraries: ``` configure: error: libgpg-error required (because of --with-local-libgcrypt) but not found or too old. ``` See: https://github.com/ntop/nDPI/actions/runs/8869020568/job/24350356867 ``` ndpi_utils.c:69:10: fatal error: 'pcre2.h' file not found ^~~~~~~~~ 1 error generated. ``` See: https://github.com/ntop/nDPI/actions/runs/8869020568/job/24349242251 Everything is still fine with macos-14 and no external dependencies As workaround, test only macos-12 and macos-13 in our main matrix.
|
|
I had the same kind of issue when I added the first basic support for macos-14 on arm64: 8fbef7f |
utoni
approved these changes
Apr 28, 2024
utoni
added a commit
to utoni/nDPId
that referenced
this pull request
May 6, 2024
* See: ntop/nDPI#2411 Signed-off-by: Toni Uhlig <matzeton@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub switched "macos-latest" from "macos-12" to "macos-14", which is only on ARM64!
actions/runner#3256
https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/
However we are having some issues build nDPI on macos-14 with external libraries:
See: https://github.com/ntop/nDPI/actions/runs/8869020568/job/24350356867
See: https://github.com/ntop/nDPI/actions/runs/8869020568/job/24349242251
Everything is still fine with macos-14 and no external dependencies
As workaround, test only macos-12 and macos-13 in our main matrix.