Allow custom implementations of nb_kernel_name
and nb_language
in papermill engines
#676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context behind this PR
At Noteable, we came across a use-case where parametrized executions with a custom Noteable engine were not working because papermill expects the
kernel_name
to be present in thekernelspec
of the notebook ifkernel_name
was not explicitly passed in as a kwarg. It throws aValueError
with the message "No kernel name found in notebook and no override provided.". Like so,What does this PR do?
This PR allows the extended engine to define custom business logic for the following:
nb_kernel_name
methodnb_language
method