2 failing test fixes for Windows platform #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surdouski
changed the title
surdouski
force-pushed
the
windows-compatability-test_utils
branch
from
d9f779b
to
0137c57
Compare
rohitsanj
requested changes
Aug 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #672 +/- ##
==========================================
- Coverage 91.90% 91.87% -0.03%
==========================================
Files 17 17
Lines 1605 1600 -5
==========================================
- Hits 1475 1470 -5
Misses 130 130
Continue to review full report at Codecov.
|
rohitsanj
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes multiple failing tests within test_exceptions.py and test_utils.py when papermill is run on the windows platform.
test_exceptions.py : test_exceptions_are_unpickleable
The previous behavior of the code created a temporary file with the incorrect permissions assigned to it resulting in a PermissionDenied error.
test_utils.py : test_chdir
The previous behavior of the code used os.path to compare against strings, which had the issue of sometimes comparing minified path strings (such as 'C:\Users\USER~1\Path\To\My\Basement') to non-minified path strings. New code uses more commonly used pathlib library to get and compare Paths.