New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds input of NotebookNode object directly #670
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #670 +/- ##
==========================================
+ Coverage 91.72% 91.90% +0.17%
==========================================
Files 17 17
Lines 1583 1605 +22
==========================================
+ Hits 1452 1475 +23
+ Misses 131 130 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the clean refactor.
What does this PR do?
User can pass an in-memory
nbformat.NotebookNode
object topm.execute_notebook
instead of requiring a path.Related to issue #444
This adds a
NotebookNodeHandler
to read the input object.A bit of refactoring was also needed to move code that expected a string:
.ipynb
and.json
file extensions byPapermillIO
read/write was moved intoget_handler
(this also made the code more DRY)Happy to take feedback, thanks!