Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 #666

Merged
merged 1 commit into from
Jun 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10"]
python-version: ["3.7", "3.8", "3.9", "3.10"]

steps:
- uses: "actions/checkout@v2"
Expand Down
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,21 +55,21 @@ If you are contributing with documentation please jump to [building documentatio

We need to install the development package before we can run the tests. If anything is confusing below, always resort to the relevant documentation.

For the most basic test runs against python 3.6 use this tox subset (callable after `pip install tox`):
For the most basic test runs against python 3.8 use this tox subset (callable after `pip install tox`):

```bash
tox -e py36
tox -e py38
```

This will just execute the unittests against python 3.6 in a new virtual env. The first run will take longer to setup the virtualenv, but will be fast after that point.
This will just execute the unittests against python 3.8 in a new virtual env. The first run will take longer to setup the virtualenv, but will be fast after that point.

For a full test suite of all envs and linting checks simply run tox without any arguments

```bash
tox
```

This will require python3.6, python3.8, and python3.7 to be installed. **Note** that python 3.7 has problems with the alpha build which is the available package version on many linux distros. Local build failures with 3.7 can happen as a result (you'll see a seg fault or exist code -11).
This will require python3.7, python3.8, python3.9 and python3.10 to be installed. **Note** that python 3.7 has problems with the alpha build which is the available package version on many linux distros. Local build failures with 3.7 can happen as a result (you'll see a seg fault or exist code -11).

Alternavitely pytest can be used if you have an environment already setup which works or has custom packages not present in the tox build.

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ pip install papermill[all]

## Python Version Support

This library currently supports Python 3.6+ versions. As minor Python
This library currently supports Python 3.7+ versions. As minor Python
versions are officially sunset by the Python org papermill will similarly
drop support in the future.

Expand Down
2 changes: 1 addition & 1 deletion docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ This opens up new opportunities for how notebooks can be used. For example:
Python Version Support
----------------------

This library currently supports python 3.6+ versions. As minor python
This library currently supports python 3.7+ versions. As minor python
versions are officially sunset by the python org papermill will similarly
drop support in the future.

Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def read_reqs(fname, folder=None):
long_description_content_type='text/markdown',
url='https://github.com/nteract/papermill',
packages=['papermill'],
python_requires='>=3.6',
python_requires='>=3.7',
install_requires=read_reqs('requirements.txt'),
extras_require=extras_require,
entry_points={'console_scripts': ['papermill = papermill.__main__:papermill']},
Expand All @@ -93,7 +93,6 @@ def read_reqs(fname, folder=None):
'License :: OSI Approved :: BSD License',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
Expand Down
4 changes: 1 addition & 3 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
[tox]
skipsdist = true
envlist = py{36,37,38,39,310}, flake8, dist, manifest, docs, binder
envlist = py{37,38,39,310}, flake8, dist, manifest, docs, binder

[gh-actions]
python =
3.6: py36
3.7: py37
3.8: py38, dist
3.9: py39
Expand Down Expand Up @@ -68,7 +67,6 @@ setenv =
AWS_SECRET_ACCESS_KEY=foobar_secret
passenv = *
basepython =
py36: python3.6
py37: python3.7
py38: python3.8
py39: python3.9
Expand Down