Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #664

Merged
merged 3 commits into from Jun 9, 2022
Merged

Fix CI #664

merged 3 commits into from Jun 9, 2022

Conversation

reoono
Copy link
Contributor

@reoono reoono commented May 18, 2022

What does this PR do?

CI jobs are failing, fix it.

At first, we will fix it starting with a simple formatting error.

Fixes #663

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #664 (c769444) into main (76906a8) will increase coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   91.18%   91.64%   +0.46%     
==========================================
  Files          17       17              
  Lines        1486     1568      +82     
==========================================
+ Hits         1355     1437      +82     
  Misses        131      131              
Impacted Files Coverage Δ
papermill/s3.py 77.61% <100.00%> (ø)
papermill/abs.py 100.00% <0.00%> (ø)
papermill/adl.py 100.00% <0.00%> (ø)
papermill/cli.py 99.13% <0.00%> (+<0.01%) ⬆️
papermill/engines.py 98.28% <0.00%> (+0.06%) ⬆️
papermill/utils.py 93.65% <0.00%> (+0.20%) ⬆️
papermill/translators.py 98.85% <0.00%> (+0.24%) ⬆️
papermill/iorw.py 79.43% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76906a8...c769444. Read the comment docs.

@reoono
Copy link
Contributor Author

reoono commented May 18, 2022

In 3.8 ~ 3.10, TestBrokenNotebook2 fails.

Comparing the results of papermill_io.read(notebook_path) with 3.7, the test fails because stderr is being output to outputs.

{
 "cells": [
  {
    ...
  },
  {
    ...
  },
  {
    ...
  },
  {
   "cell_type": "code",
   "execution_count": 2,
   "id": "a29dda52",
   "metadata": {
    "execution": {
     "iopub.execute_input": "2022-05-18T19:18:57.491381Z",
     "iopub.status.busy": "2022-05-18T19:18:57.491027Z",
     "iopub.status.idle": "2022-05-18T19:18:57.764096Z",
     "shell.execute_reply": "2022-05-18T19:18:57.763670Z"
    },
    "papermill": {
     "duration": 0.284906,
     "end_time": "2022-05-18T19:18:57.764818",
     "exception": true,
     "start_time": "2022-05-18T19:18:57.479912",
     "status": "failed"
    },
    "tags": []
   },
   "outputs": [
    {
     "name": "stderr",
     "output_type": "stream",
     "text": [
      "/tmp/ipykernel_127658/3114338127.py:2: DeprecationWarning: Importing display from IPython.core.display is deprecated since IPython 7.14, please import from IPython display\n",
      "  from IPython.core.display import display, HTML\n"
     ]
    },
    {
     "data": {
      "text/html": [
       "<style>.container { width:100% !important; }</style>"
      ],
      "text/plain": [
       "<IPython.core.display.HTML object>"
      ]
     },
     "metadata": {},
     "output_type": "display_data"
    },
    {
     "ename": "AssertionError",
     "evalue": "",
     "output_type": "error",
     "traceback": [
      "\u001b[0;31m---------------------------------------------------------------------------\u001b[0m",
      "\u001b[0;31mAssertionError\u001b[0m                            Traceback (most recent call last)",
      "Input \u001b[0;32mIn [2]\u001b[0m, in \u001b[0;36m<cell line: 5>\u001b[0;34m()\u001b[0m\n\u001b[1;32m      2\u001b[0m \u001b[38;5;28;01mfrom\u001b[39;00m \u001b[38;5;21;01mIPython\u001b[39;00m\u001b[38;5;21;01m.\u001b[39;00m\u001b[38;5;21;01mcore\u001b[39;00m\u001b[38;5;21;01m.\u001b[39;00m\u001b[38;5;21;01mdisplay\u001b[39;00m \u001b[38;5;28;01mimport\u001b[39;00m display, HTML\n\u001b[1;32m      3\u001b[0m display(HTML(\u001b[38;5;124m\"\u001b[39m\u001b[38;5;124m<style>.container \u001b[39m\u001b[38;5;124m{\u001b[39m\u001b[38;5;124m width:100\u001b[39m\u001b[38;5;124m%\u001b[39m\u001b[38;5;124m !important; }</style>\u001b[39m\u001b[38;5;124m\"\u001b[39m))\n\u001b[0;32m----> 5\u001b[0m \u001b[38;5;28;01massert\u001b[39;00m \u001b[38;5;28;01mFalse\u001b[39;00m\n",
      "\u001b[0;31mAssertionError\u001b[0m: "
     ]
    }
   ],
   "source": [
    "# This causes multiple output elements to be created, one of type \"display_data\" and another of type \"error.\"\n",
    "from IPython.core.display import display, HTML\n",
    "display(HTML(\"<style>.container { width:100% !important; }</style>\"))\n",
    "\n",
    "assert False"
   ]
  },
  {
    ...
  }
 ],
 "metadata": {
     ...
  },
  "papermill": {
      ...
  }
 },
 "nbformat": 4,
 "nbformat_minor": 5
}

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@reoono
Copy link
Contributor Author

reoono commented May 18, 2022

After changing to the recommended method as follows, I no longer get multiple outputs.
Therefore, I have suppressed DeprecatedWarnings on import.

from IPython import display
display.HTML("<style>.container { width:100% !important; }</style>")

@reoono reoono changed the title [WIP] Fix CI Fix CI May 18, 2022
@reoono
Copy link
Contributor Author

reoono commented May 18, 2022

@MSeal
The work has been completed, please check when you are available.
Thank you for your cooperation.

Copy link
Member

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@MSeal MSeal merged commit 43b6712 into nteract:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken CI
2 participants