Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read notebook from github #622

Merged
merged 3 commits into from Jul 27, 2021
Merged

Read notebook from github #622

merged 3 commits into from Jul 27, 2021

Conversation

onevirus
Copy link
Contributor

  • Add GithubHandler
  • Add requirements for GithubHandler

Now we can use https://github.com/.../blob/...ipynb as input path.
Use GITHUB_ACCESS_TOKEN environment variable for accessing private repo.

Fixes #556

MSeal
MSeal approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out and it appears to work as advertised. It'd also be neat to support the ssh git uri patterns down the road too.

@MSeal
Copy link
Member

MSeal commented Jul 27, 2021

Error is unrelated to PR -- GCS filesystem had a breaking change it looks like.

@MSeal MSeal merged commit b5b787e into nteract:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSeal MSeal MSeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New feature: Read input notebook from github
2 participants
@onevirus @MSeal