Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): only add release config for publishable librarires #30474

Conversation

beaussan
Copy link
Contributor

@beaussan beaussan commented Mar 24, 2025

Current Behavior

When generating a library that is not published but has a build step, then release targets, verdaccio and nx release are configured

Expected Behavior

When a library is only built, but not published, none of the release setup is done

Verified

This commit was signed with the committer’s verified signature.
MichaelDeBoey Michaël De Boey
Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 24, 2025 6:59am

Copy link

nx-cloud bot commented Mar 24, 2025

View your CI Pipeline Execution ↗ for commit 0082b0b.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 27m 18s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 17s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=cecd6... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-24 07:29:22 UTC

@beaussan beaussan marked this pull request as ready for review March 24, 2025 06:58
@beaussan beaussan requested a review from a team as a code owner March 24, 2025 06:58
@beaussan beaussan requested a review from mandarini March 24, 2025 06:58
@JamesHenry JamesHenry merged commit 3d710ce into nrwl:master Mar 24, 2025
12 checks passed
FrozenPandaz pushed a commit that referenced this pull request Mar 25, 2025
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants