Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): legacy cache users should get artifacts when remote cache is hit #30442

Merged
merged 1 commit into from
Mar 20, 2025
Merged

fix(core): legacy cache users should get artifacts when remote cache is hit #30442

merged 1 commit into from
Mar 20, 2025
+3 −3

Conversation

AgentEnder
Copy link
Member

Current Behavior

Expected Behavior

Legacy cache users should get artifacts when remote cache is hit

Related Issue(s)

Fixes #30429

@AgentEnder
fix(core): legacy cache users should get artifacts when remote cache …

Verified

This commit was signed with the committer’s verified signature. The key has expired.
zakkak Foivos Zakkak
GPG key ID: 0846BFD103F04EA1
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
2dd2683 
…is hit
@AgentEnder AgentEnder requested a review from a team as a code owner March 20, 2025 16:31
@AgentEnder AgentEnder requested a review from Cammisuli March 20, 2025 16:31
@vercel Vercel
Copy link

vercel bot commented Mar 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2025 4:32pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 20, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2dd2683.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 36m 16s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=f9c8d... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-20 17:13:50 UTC

@AgentEnder AgentEnder merged commit 3e8ba40 into master Mar 20, 2025
12 checks passed
@AgentEnder AgentEnder deleted the fix/legacy-cache-remote-hits branch March 20, 2025 17:15
FrozenPandaz pushed a commit that referenced this pull request Mar 20, 2025
@AgentEnder @FrozenPandaz
fix(core): legacy cache users should get artifacts when remote cache …

Verified

This commit was signed with the committer’s verified signature. The key has expired.
zakkak Foivos Zakkak
GPG key ID: 0846BFD103F04EA1
Expired
Verified
Learn about vigilant mode
e4e9283 
…is hit (#30442)

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
Legacy cache users should get artifacts when remote cache is hit

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #30429

(cherry picked from commit 3e8ba40)
@AgentEnder AgentEnder mentioned this pull request Mar 24, 2025
Closed
4 tasks
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz

@Cammisuli Cammisuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cached output is not restored
2 participants
@AgentEnder @FrozenPandaz