fix(js): update tinyglobby to speed up shallow file matching #30415
+233
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysoo
requested review from
a team,
FrozenPandaz,
vsavkin,
AgentEnder and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit f12cb13.
☁️ Nx Cloud last updated this comment at |
jaysoo
force-pushed
the
fix/tinyglobby-slowness
branch
from
b40c104 to
f12cb13
Compare
JamesHenry
approved these changes
Mar 18, 2025
FrozenPandaz
approved these changes
Mar 19, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 19, 2025
`tinyglobby` at `0.2.10` (what we use now) is slow on shallow files, but the latest version `0.2.12` is fast due to this PR https://github.com/SuperchupuDev/tinyglobby/pull/69/files. This PR updates both the js and esbuild plugins to use the newest versions, but also adds `tinyglobby@^0.2.12` to our root `package.json` so we get the speed increase right away. I removed `fast-glob` in our repo scripts and replaced it with `tinyglobby`. Asset handling is slow for shallow files like `LICENSE` but is fine for scoped patterns like `src/**/*.ts`. Asset handling should be fast for shallow files. <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit e0cae53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tinyglobbyat0.2.10(what we use now) is slow on shallow files, but the latest version0.2.12is fast due to this PR https://github.com/SuperchupuDev/tinyglobby/pull/69/files.This PR updates both the js and esbuild plugins to use the newest versions, but also adds
tinyglobby@^0.2.12to our rootpackage.jsonso we get the speed increase right away. I removedfast-globin our repo scripts and replaced it withtinyglobby.Current Behavior
Asset handling is slow for shallow files like
LICENSEbut is fine for scoped patterns likesrc/**/*.ts.Expected Behavior
Asset handling should be fast for shallow files.
Related Issue(s)
Fixes #