Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle nx config in package.json in move generator #30270

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

leosvelperez
Copy link
Member

Current Behavior

When the Nx configuration is in package.json#nx and not in project.json, the move generator creates a project.json file in the new destination.

Expected Behavior

When the Nx configuration is in package.json#nx and not in project.json, the move generator should not create a project.json file in the new destination and should update the nx entry in the package.json file.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 5, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner March 5, 2025 12:02
Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 0:02am

Copy link

nx-cloud bot commented Mar 5, 2025

View your CI Pipeline Execution ↗ for commit e21db83.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 7m 11s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=e8aca... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 56s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-05 14:01:09 UTC

@leosvelperez leosvelperez enabled auto-merge (squash) March 5, 2025 13:33
@leosvelperez leosvelperez merged commit e4f7e56 into master Mar 5, 2025
12 checks passed
@leosvelperez leosvelperez deleted the workspace/move-handle-package.json-nx-config branch March 5, 2025 14:01
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants