Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): correct mapping for reportsDirectory when using executors #30232

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

ndcunningham
Copy link
Contributor

Using vitest whenever we merge configs from executors and the config file. The executors should override the option which has be set inside of the config file.

Current Behavior

The reportsDirectory option which can be set when using @nx/vite:test is not override the generated coverage directory path.

Expected Behavior

When the @nx/vite:test executor runs the option reportsDirectory should override the option set inside vite.config

Related Issue(s)

Fixes #30223

@ndcunningham ndcunningham self-assigned this Feb 28, 2025
@ndcunningham ndcunningham requested a review from a team as a code owner February 28, 2025 19:35
@ndcunningham ndcunningham requested a review from jaysoo February 28, 2025 19:35
Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 8:37pm

Copy link

nx-cloud bot commented Feb 28, 2025

View your CI Pipeline Execution ↗ for commit a12cff5.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 36m 15s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 43s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-28 21:16:50 UTC

@ndcunningham ndcunningham force-pushed the fix/vitest-coverage-directory branch from 662fa0d to a12cff5 Compare February 28, 2025 20:34
@ndcunningham ndcunningham merged commit 8e6c007 into master Mar 4, 2025
12 checks passed
@ndcunningham ndcunningham deleted the fix/vitest-coverage-directory branch March 4, 2025 02:01
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/vite:test doesn't respect reportsDirectory when set in project.json
2 participants