fix(bundling): fix esbuild to work with ts project references #30230
+332
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 0441df8.
☁️ Nx Cloud last updated this comment at |
leosvelperez
requested changes
Mar 3, 2025
packages/esbuild/src/executors/esbuild/lib/build-esbuild-options.ts
Outdated
Show resolved
Hide resolved
packages/esbuild/src/executors/esbuild/lib/build-esbuild-options.ts
Outdated
Show resolved
Hide resolved
packages/esbuild/src/executors/esbuild/lib/build-esbuild-options.ts
Outdated
Show resolved
Hide resolved
packages/esbuild/src/executors/esbuild/lib/build-esbuild-options.ts
Outdated
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ndcunningham
force-pushed
the
fix/esbuild-ts-references
branch
from
c00e38c to
000b9c8
Compare
jaysoo
reviewed
Mar 4, 2025
packages/esbuild/src/executors/esbuild/lib/build-esbuild-options.ts
Outdated
Show resolved
Hide resolved
jaysoo
reviewed
Mar 4, 2025
packages/esbuild/src/executors/esbuild/lib/build-esbuild-options.ts
Outdated
Show resolved
Hide resolved
ndcunningham
force-pushed
the
fix/esbuild-ts-references
branch
from
000b9c8 to
ee571f4
Compare
ndcunningham
force-pushed
the
fix/esbuild-ts-references
branch
from
ee571f4 to
6c3c8f8
Compare
jaysoo
approved these changes
Mar 4, 2025
ndcunningham
force-pushed
the
fix/esbuild-ts-references
branch
from
6c3c8f8 to
75778aa
Compare
leosvelperez
approved these changes
Mar 5, 2025
ndcunningham
force-pushed
the
fix/esbuild-ts-references
branch
from
75778aa to
0441df8
Compare
4 tasks
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
If we are using
esbuildas our bundler and ts project references (--workspaces) local libraries are not building are not resolved in the build artifacts.Expected Behavior
When using ts project references with esbuild all types libraries (buildable / non-buildable) should work out of the box.
Related Issue(s)
Fixes #