Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): copy assets plugin not copying files in watch mode #30141 #30208

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 27, 2025

Current Behavior

Copy assets plugin for Vite is not copying files in watch mode when those files are changed.

This is due to the path being incorrect after calculation.
There is also no indication to the user that the copy completed at all.

Expected Behavior

Fix path calculation to allow copy to occur correctly

Output the relative dest of the file after copy completed.

Related Issue(s)

Fixes #30141

@Coly010 Coly010 requested a review from a team as a code owner February 27, 2025 16:59
@Coly010 Coly010 requested a review from JamesHenry February 27, 2025 16:59
@Coly010 Coly010 self-assigned this Feb 27, 2025
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 9:41am

Copy link

nx-cloud bot commented Feb 27, 2025

View your CI Pipeline Execution ↗ for commit 55b3a34.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 39m 17s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 1m 35s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-28 10:23:12 UTC

@Coly010 Coly010 force-pushed the vite/fix-copy-assets-plugin-watch branch from 49be204 to 55b3a34 Compare February 28, 2025 09:38
@Coly010 Coly010 merged commit 30f5a52 into master Feb 28, 2025
12 checks passed
@Coly010 Coly010 deleted the vite/fix-copy-assets-plugin-watch branch February 28, 2025 11:07
Copy link

github-actions bot commented Mar 6, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite nxCopyAssetsPlugin does not copy assets in watch mode
2 participants