Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): add setup generator for Tailwind CSS fixes absolute pathing #30192

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

ndcunningham
Copy link
Contributor

Current Behavior

When we generate a Next.js application with tailwindcss running with --turbo fails due to how the globs are defined inside tailwind.config.js.

Expected Behavior

Relative paths a singular globs are required with this change tailwind should work with HMR using --turbo

Related Issue(s)

Fixes #29946

@ndcunningham ndcunningham self-assigned this Feb 26, 2025
@ndcunningham ndcunningham requested a review from a team as a code owner February 26, 2025 18:39
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 8:25pm

@ndcunningham ndcunningham added the scope: nextjs Issues related to NextJS support for Nx label Feb 26, 2025
Copy link

nx-cloud bot commented Feb 26, 2025

View your CI Pipeline Execution ↗ for commit 99d592f.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 23m 57s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 1m 27s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-26 20:50:03 UTC

@ndcunningham ndcunningham force-pushed the fix/nextjs-tailwind-relative-paths branch from 75ea4b6 to c00c67a Compare February 26, 2025 19:38
@ndcunningham ndcunningham force-pushed the fix/nextjs-tailwind-relative-paths branch from c00c67a to 7927be8 Compare February 26, 2025 19:59
@ndcunningham ndcunningham force-pushed the fix/nextjs-tailwind-relative-paths branch 2 times, most recently from 157c8a2 to dec733d Compare February 26, 2025 20:19
@ndcunningham ndcunningham force-pushed the fix/nextjs-tailwind-relative-paths branch from dec733d to 99d592f Compare February 26, 2025 20:20
@ndcunningham ndcunningham merged commit 6d40b6a into master Feb 26, 2025
12 checks passed
@ndcunningham ndcunningham deleted the fix/nextjs-tailwind-relative-paths branch February 26, 2025 21:55
Copy link

github-actions bot commented Mar 4, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: nextjs Issues related to NextJS support for Nx
Projects
None yet
2 participants